ricardozanini commented on code in PR #1895: URL: https://github.com/apache/incubator-kie-kogito-examples/pull/1895#discussion_r1528638072
########## serverless-workflow-examples/sonata-workflow-fluent/pom.xml: ########## @@ -0,0 +1,49 @@ +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.kie.kogito.examples</groupId> + <artifactId>serverless-workflow-examples</artifactId> + <version>999-SNAPSHOT</version> + </parent> + <artifactId>sonata-workflow-fluent</artifactId> + <name>Kogito Example :: Sonata Workflow:: Java Embedded examples</name> + <properties> + <kogito.bom.group-id>org.kie.kogito</kogito.bom.group-id> + <kogito.bom.artifact-id>kogito-bom</kogito.bom.artifact-id> + <kogito.bom.version>999-SNAPSHOT</kogito.bom.version> + <maven.compiler.release>17</maven.compiler.release> + <java.module.name>SonataWorkflowFluent</java.module.name> Review Comment: ```suggestion <java.module.name>SonataFlowFluent</java.module.name> ``` ########## serverless-workflow-examples/sonata-workflow-fluent/pom.xml: ########## @@ -0,0 +1,49 @@ +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.kie.kogito.examples</groupId> + <artifactId>serverless-workflow-examples</artifactId> + <version>999-SNAPSHOT</version> + </parent> + <artifactId>sonata-workflow-fluent</artifactId> + <name>Kogito Example :: Sonata Workflow:: Java Embedded examples</name> + <properties> + <kogito.bom.group-id>org.kie.kogito</kogito.bom.group-id> + <kogito.bom.artifact-id>kogito-bom</kogito.bom.artifact-id> + <kogito.bom.version>999-SNAPSHOT</kogito.bom.version> + <maven.compiler.release>17</maven.compiler.release> + <java.module.name>SonataWorkflowFluent</java.module.name> + </properties> + <dependencyManagement> + <dependencies> + <dependency> + <groupId>${kogito.bom.group-id}</groupId> + <artifactId>${kogito.bom.artifact-id}</artifactId> + <version>${kogito.bom.version}</version> + <type>pom</type> + <scope>import</scope> + </dependency> + </dependencies> + </dependencyManagement> + <dependencies> + <dependency> + <groupId>org.kie.kogito</groupId> + <artifactId>kogito-serverless-workflow-executor</artifactId> Review Comment: Can we do the renaming now? ########## serverless-workflow-examples/sonata-workflow-fluent/pom.xml: ########## @@ -0,0 +1,49 @@ +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.kie.kogito.examples</groupId> + <artifactId>serverless-workflow-examples</artifactId> + <version>999-SNAPSHOT</version> + </parent> + <artifactId>sonata-workflow-fluent</artifactId> + <name>Kogito Example :: Sonata Workflow:: Java Embedded examples</name> Review Comment: ```suggestion <name>Kogito Example :: SonataFlow :: Java Embedded examples</name> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
