yesamer commented on code in PR #2207:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2207#discussion_r1572090068


##########
packages/dmn-testing-models/README.md:
##########
@@ -0,0 +1,20 @@
+## DMN testing models
+
+This package is meant to contain all the DMN models published inside 
[kie-dmn-test-resources](https://github.com/apache/incubator-kie-drools/tree/main/kie-dmn/kie-dmn-test-resources)
 to make them available for testing purposes.
+
+Models are separated between < 1.5 version and 1.5 version; such 
classification is based on actual version-specific features, and not on the 
referenced tag itself.
+
+For future DMN versions there will be version specific folders.
+
+The original `org.kie:kie-dmn-test-resources` also contains _invalid_ models, 
but for the moment being we use only the valid ones to verify round-trip 
validation.
+
+### Usage
+
+The command `mvn clean generate-resources` downloads the jar and extract the 
models under `dist/`.
+
+To make them available for testing purpose:
+
+1. set the `KOGITO_RUNTIME_version` in the terminal (if different from the 
default one)
+2. `pnpm bootstrap` on the root directory
+3. cd dmn-testing-models
+4. `pnpm build:dev` or `pnpm build:prod` (they behave the same way - this 
executes `mvn clean generate-resources`)

Review Comment:
   Done



##########
packages/dmn-testing-models/README.md:
##########
@@ -0,0 +1,20 @@
+## DMN testing models
+
+This package is meant to contain all the DMN models published inside 
[kie-dmn-test-resources](https://github.com/apache/incubator-kie-drools/tree/main/kie-dmn/kie-dmn-test-resources)
 to make them available for testing purposes.
+
+Models are separated between < 1.5 version and 1.5 version; such 
classification is based on actual version-specific features, and not on the 
referenced tag itself.
+
+For future DMN versions there will be version specific folders.
+
+The original `org.kie:kie-dmn-test-resources` also contains _invalid_ models, 
but for the moment being we use only the valid ones to verify round-trip 
validation.
+
+### Usage
+
+The command `mvn clean generate-resources` downloads the jar and extract the 
models under `dist/`.

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to