elguardian commented on code in PR #3481:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3481#discussion_r1575814999
##########
addons/common/monitoring/core/src/main/java/org/kie/kogito/monitoring/core/common/process/MetricsProcessEventListener.java:
##########
@@ -57,29 +61,30 @@ public MetricsProcessEventListener(String identifier,
KogitoGAV gav, MeterRegist
}
private Counter getNumberOfProcessInstancesStartedCounter(String appId,
String processId) {
- return Counter
- .builder("kogito_process_instance_started_total")
- .description("Started Process Instances")
- .tags(Arrays.asList(Tag.of("app_id", appId),
Tag.of("process_id", processId), Tag.of("artifactId", gav.getArtifactId()),
Tag.of("version", gav.getVersion())))
- .register(meterRegistry);
+ return buildCounter("kogito_process_instance_started_total", "Started
Process Instances", appId, processId);
+ }
+
+ private Counter getErrorCounter(String appId, String processId, String
errorMessage) {
+ return buildCounter("kogito_process_instance_error", "Process
instances currently in error state", appId, processId, Tag.of("error_message",
errorMessage));
Review Comment:
I would argue howmany errors did occur.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
