tkobayas commented on code in PR #5869:
URL:
https://github.com/apache/incubator-kie-drools/pull/5869#discussion_r1578801246
##########
drools-model/drools-canonical-model/src/main/java/org/drools/model/operators/InOperator.java:
##########
@@ -20,16 +20,16 @@
import org.drools.model.functions.Operator;
+import static org.drools.model.util.OperatorUtils.areEqual;
+
public enum InOperator implements Operator.MultipleValue<Object, Object> {
INSTANCE;
@Override
public boolean eval( Object a, Object[] bs ) {
for (Object b : bs) {
- if (a == null && b == null) {
- return true;
- } else if (a != null && a.equals( b )) {
+ if (areEqual(a, b)) {
Review Comment:
`OperatorUtils.areEqual` supports numeric equal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
