yurloc commented on code in PR #5871:
URL: 
https://github.com/apache/incubator-kie-drools/pull/5871#discussion_r1581028687


##########
drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/DRLParser.g4:
##########
@@ -123,6 +123,7 @@ lhsUnary : (
            | lhsEval consequenceInvocation*
            | lhsForall
            | lhsAccumulate
+           | LPAREN lhsExpression RPAREN namedConsequenceInvocation?

Review Comment:
   @tkobayas I confess that I do not 100% understand how exactly the changes in 
this PR work. In an attempt to better understand how individual changes 
contribute to the fix, I experimented and reverted parts of the PR.
   
   I _accidentally_ found out this specific addition appears to be redundant. 
Everything seems to work as expected even without this line. Please reconsider 
this addition and see if you can find a good reason to remove it. If uncertain, 
feel free to keep it there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to