wmedvede commented on code in PR #456:
URL: 
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/456#discussion_r1583466755


##########
controllers/builder/openshiftbuilder.go:
##########
@@ -196,6 +196,15 @@ func (o *openshiftBuilderManager) 
addExternalResources(config *buildv1.BuildConf
                        DestinationDir: workflowRes.WorkflowPath,
                })
        }
+       //TODO WM remove this comment
+       //make the workflow properties available to the OpenShift build config.
+       configMapSources = append(configMapSources, 
buildv1.ConfigMapBuildSource{

Review Comment:
   @ricardozanini for the OpenShift build, we do something similar than with 
the kaniko build task. And we basically add the application.properties to the 
build.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to