tkobayas commented on PR #5958: URL: https://github.com/apache/incubator-kie-drools/pull/5958#issuecomment-2119692538
> I have to request a change. I don't have the time to investigate this fully but there is a problem with the new keyword. It might need a special treatment because at this state the PR breaks org.drools.mvel.integrationtests.JittingTest#testBigDecimalConstructorCoercion: Thanks @yurloc ! I excluded `new` from `drlIdentifier`. We may be able to solve the issue by modifying `primary` rule etc., but it would complicate the difference between the old and new parser, so it would make the future investigation harder. I think at this stage, it' better to go for a simple fix to pass existing unit tests and, list any backward compatibility issues in https://github.com/apache/incubator-kie-drools/issues/5962 , so we can evaluate them in the next round. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
