jianrongzhang89 commented on code in PR #467:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/467#discussion_r1626244519
##########
api/condition_types.go:
##########
@@ -39,6 +39,8 @@ const (
SucceedConditionType ConditionType = "Succeed"
// BuiltConditionType describes the condition of a resource that needs
to be build.
BuiltConditionType ConditionType = "Built"
+ // DeployedConditionType describes the condition of a resource that
needs to be deployed.
+ DeployedConditionType ConditionType = "Deployed"
Review Comment:
OK. It is removed.
##########
controllers/knative/knative.go:
##########
@@ -64,8 +81,23 @@ func NewKnativeEventingClient(cfg *rest.Config)
(*clienteventingv1.EventingV1Cli
return clienteventingv1.NewForConfig(cfg)
}
+func GetDisvoveryClient(cfg *rest.Config) (discovery.DiscoveryInterface,
error) {
+ if discoveryClient == nil {
+ if cli, err := discovery.NewDiscoveryClientForConfig(cfg); err
!= nil {
+ return nil, err
+ } else {
+ discoveryClient = cli
+ }
+ }
+ return discoveryClient, nil
+}
+
+func SetDisvoveryClient(cli discovery.DiscoveryInterface) {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
