gitgabrio commented on code in PR #5994:
URL:
https://github.com/apache/incubator-kie-drools/pull/5994#discussion_r1642643059
##########
kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/extended/StringJoinFunction.java:
##########
@@ -55,6 +55,10 @@ public FEELFnResult<String> invoke(@ParameterName("list")
List<?> list, @Paramet
return FEELFnResult.ofResult(sj.toString());
}
+ public FEELFnResult<String> invoke(@ParameterName("list") String
stringValue, @ParameterName("delimiter") String delimiter) {
Review Comment:
Hi @yesamer
I'm confused about this implementation.
Reading the tests, the Join function works only when two (or more) Strings
are provided. But this method receives only one string and the delimeter, in
which case (IINW) it should not do anything...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
