martinweiler commented on code in PR #3549:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3549#discussion_r1643434130


##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/IntermediateEventTest.java:
##########
@@ -125,6 +131,34 @@ public void beforeNodeTriggered(ProcessNodeTriggeredEvent 
event) {
      * TESTS!
      */
 
+    @Test
+    public void testBoundaryTimerCycleISO() {
+        Application app = ProcessTestHelper.newApplication();
+        NodeLeftCountDownProcessEventListener listener = new 
NodeLeftCountDownProcessEventListener("Send Update", 3);
+        ProcessTestHelper.registerProcessEventListener(app, listener);
+        org.kie.kogito.process.Process<BoundaryTimerCycleISOModel> definition 
= BoundaryTimerCycleISOProcess.newProcess(app);
+        org.kie.kogito.process.ProcessInstance<BoundaryTimerCycleISOModel> 
instance = definition.createInstance(definition.createModel());
+        instance.start();
+        listener.waitTillCompleted();
+        ProcessTestHelper.completeWorkItem(instance, "john", 
Collections.emptyMap());
+        
assertThat(instance.status()).isEqualTo(org.kie.kogito.process.ProcessInstance.STATE_COMPLETED);
+    }
+
+    @Test
+    public void testBoundaryTimerCycleISOVariable() {
+        Application app = ProcessTestHelper.newApplication();
+        NodeLeftCountDownProcessEventListener listener = new 
NodeLeftCountDownProcessEventListener("Send Update", 3);
+        ProcessTestHelper.registerProcessEventListener(app, listener);
+        org.kie.kogito.process.Process<BoundaryTimerCycleISOVariableModel> 
definition = BoundaryTimerCycleISOVariableProcess.newProcess(app);
+        BoundaryTimerCycleISOVariableModel model = definition.createModel();
+        model.setCronStr("R3/PT0.1S");

Review Comment:
   Despite the 0.1s change, both tests still take 10s to complete:
   ```
   [INFO] Running org.jbpm.bpmn2.IntermediateEventTest
   2024-06-17 15:09:22,445 [main] INFO   >>> 
testBoundaryTimerCycleISOVariable() <<<
   Finish Work
   2024-06-17 15:09:23,557 [pool-2-thread-1] INFO  Job 
f96572f2-02f7-4228-8ca8-2f8a7999da45 started
   Sending Update...
   2024-06-17 15:09:23,691 [pool-2-thread-1] INFO  Job 
f96572f2-02f7-4228-8ca8-2f8a7999da45 started
   Sending Update...
   2024-06-17 15:09:23,756 [pool-2-thread-2] INFO  Job 
f96572f2-02f7-4228-8ca8-2f8a7999da45 started
   Sending Update...
   2024-06-17 15:09:32,603 [main] INFO  Finished 
testBoundaryTimerCycleISOVariable()
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to