tiagobento commented on code in PR #2433:
URL:
https://github.com/apache/incubator-kie-tools/pull/2433#discussion_r1643553175
##########
.ci/incubator-kie-tools-ci-build.Dockerfile:
##########
@@ -1,4 +1,4 @@
-FROM cruizba/ubuntu-dind:noble-26.1.3
+FROM cruizba/ubuntu-dind:jammy-26.1.3
Review Comment:
What's the difference between "noble" and "jammy"? :D
##########
.ci/jenkins/Jenkinsfile.ci-main:
##########
@@ -54,8 +53,7 @@ pipeline {
"https://github.com/${pipelineVars.githubRepositoryOrg}/${pipelineVars.githubRepositoryName}.git";,
"${pipelineVars.kieToolsBotGithubCredentialsId}"
)
-
- BUILD_IMAGE_REQUIRED =
githubUtils.fileIsInChangeset('incubator-kie-tools-ci-build.Dockerfile')
+ BUILD_IMAGE_REQUIRED = (BRANCH_NAME != 'main' ||
githubUtils.fileIsInChangeset('incubator-kie-tools-ci-build.Dockerfile'))
Review Comment:
Is `BRANCH_NAME != 'main'` for the case of new branches? If so, maybe we
could have a way to check if a tag for that stream exists or not, right?
Because otherwise, all PRs for non-`main` branches will re-build the image, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
