danielzhe commented on PR #2456: URL: https://github.com/apache/incubator-kie-tools/pull/2456#issuecomment-2231260985
> I know it's a personal preference, I see some public methods, but none are marked as private. Even though TS/JS allows this I personally don't think it's considered good practice as it's not explicitly telling what the variable/method is. As I said, feel free to leave like this though. If we want to force some standardization that is just a "personal preference", we should force it in ESLint. Also, yes, it has private methods -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
