kbowers-ibm commented on code in PR #2441:
URL:
https://github.com/apache/incubator-kie-tools/pull/2441#discussion_r1682448338
##########
packages/scesim-editor/tests-e2e/__fixtures__/table.ts:
##########
@@ -44,33 +44,57 @@ export class Table {
: await this.page.getByRole("menuitem", { name: "Insert Above"
}).click();
}
- public async addPropertyColumn(args: { targetCellName: string; position:
AddColumnPosition; nth: number }) {
- await this.page.getByRole("columnheader", { name: args.targetCellName
}).nth(args.nth).click({ button: "right" });
+ public async addPropertyColumn(args: { targetCellName: string; position:
AddColumnPosition; columnNumber: number }) {
+ await this.page
+ .getByRole("columnheader", { name: args.targetCellName })
+ .nth(args.columnNumber)
+ .click({ button: "right" });
args.position === AddColumnPosition.LEFT
? await this.page.getByRole("menuitem", { name: "Insert Field Left"
}).click()
: await this.page.getByRole("menuitem", { name: "Insert Field Right"
}).click();
}
- public async addInstanceColumn(args: { targetCellName: string; position:
AddColumnPosition }) {
- await this.page.getByRole("columnheader", { name: args.targetCellName
}).click({ button: "right" });
+ public async addInstanceColumn(args: { targetCellName: string; position:
AddColumnPosition; columnNumber?: number }) {
+ args.columnNumber === undefined
+ ? await this.page.getByRole("columnheader", { name: args.targetCellName
}).click({ button: "right" })
+ : await this.page
+ .getByRole("columnheader", { name: args.targetCellName })
+ .nth(args.columnNumber)
+ .click({ button: "right" });
+
args.position === AddColumnPosition.LEFT
? await this.page.getByRole("menuitem", { name: "Insert Instance Left"
}).click()
: await this.page.getByRole("menuitem", { name: "Insert Instance Right"
}).click();
}
+
public async selectCell(args: { rowNumber: string; columnNumber: number }) {
await this.page
.getByRole("row", { name: args.rowNumber })
.getByTestId("monaco-container")
.nth(args.columnNumber)
.click();
}
- public getColumnHeader(args: { name: string }) {
- return this.page.getByRole("columnheader", { name: args.name });
+
+ public async selectColumnHeader(args: { name: string; columnNumber?: number
}) {
+ args.columnNumber === undefined
+ ? await this.page.getByRole("columnheader", { name: args.name }).click()
+ : await this.page.getByRole("columnheader", { name: args.name
}).nth(args.columnNumber).click();
}
public getCell(args: { rowNumber: string; columnNumber: number }) {
return this.page.getByRole("row", { name: args.rowNumber
}).nth(args.columnNumber);
}
+
+ public getNumberedCell(args: { name: string }) {
+ return this.page.getByRole("cell", { name: args.name });
+ }
+
+ public getColumnHeader(args: { name: string; columnNumber?: number }) {
+ return args.columnNumber === undefined
+ ? this.page.getByRole("columnheader", { name: args.name })
+ : this.page.getByRole("columnheader", { name: args.name
}).nth(args.columnNumber);
Review Comment:
Thank you! I knew there was a way to do it, but couldn't quite think of it.
Implementing👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
