pibizza commented on code in PR #3583:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3583#discussion_r1686097011
##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/ActivityTest.java:
##########
@@ -1246,21 +1250,23 @@ public void testServiceTaskWithMvelJaxbTransformation()
throws Exception {
}
+ //This test fails
@Test
- public void testErrorBetweenProcessesProcess() throws Exception {
- kruntime =
createKogitoProcessRuntime("org/jbpm/bpmn2/subprocess/BPMN2-ErrorsBetweenProcess.bpmn2",
-
"org/jbpm/bpmn2/subprocess/BPMN2-ErrorsBetweenSubProcess.bpmn2");
-
- Map<String, Object> variables = new HashMap<>();
-
- variables.put("tipoEvento", "error");
- variables.put("pasoVariable", 3);
- KogitoProcessInstance processInstance =
kruntime.startProcess("ErrorsBetweenProcess", variables);
-
- assertProcessInstanceCompleted(processInstance.getStringId(),
kruntime);
- assertProcessInstanceAborted(processInstance.getStringId() + 1,
kruntime);
-
- assertProcessVarValue(processInstance, "event", "error desde
Subproceso");
+ public void testErrorBetweenProcessesProcess() {
+ Application app = ProcessTestHelper.newApplication();
+ org.kie.kogito.process.Process<ErrorsBetweenSubProcessModel>
errorsBetweenSubProcessProcess = ErrorsBetweenSubProcessProcess.newProcess(app);
+ ProcessInstance<ErrorsBetweenSubProcessModel> subProcessInstance =
errorsBetweenSubProcessProcess
+ .createInstance(errorsBetweenSubProcessProcess.createModel());
+ org.kie.kogito.process.Process<ErrorsBetweenProcessModel> process =
ErrorsBetweenProcessProcess.newProcess(app);
+ ErrorsBetweenProcessModel model = process.createModel();
+ model.setTipoEvento("error");
+ model.setPasoVariable(3);
+ ProcessInstance<ErrorsBetweenProcessModel> processInstance =
process.createInstance(model);
+ processInstance.start();
+
assertThat(processInstance.status()).isEqualTo(ProcessInstance.STATE_COMPLETED);
+ //expected state of sub process should be aborted. But we are getting
state pending
+
assertThat(subProcessInstance.status()).isEqualTo(ProcessInstance.STATE_ABORTED);
+ Assertions.assertEquals("error desde Subproceso",
processInstance.variables().getEvent());
Review Comment:
```suggestion
assertThat(processInstance.variables().getEvent()).isEqualTo("error
desde Subproceso");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
