tiagobento commented on code in PR #2477:
URL:
https://github.com/apache/incubator-kie-tools/pull/2477#discussion_r1687233516
##########
packages/dmn-editor/src/mutations/updateExpression.ts:
##########
@@ -64,4 +65,12 @@ export function updateExpression({
} else {
throw new Error("DMN MUTATION: Can't update expression for drgElement that
is not a Decision or a BKM.");
}
+
+ getNewDmnIdRandomizer()
+ .ack({
+ json: definitions.drgElement,
+ type: "DMN15__tDefinitions",
+ attr: "drgElement",
+ })
+ .randomize();
Review Comment:
This is not necessary with the ids being added in all places we need, right?
##########
packages/boxed-expression-component/src/expressions/ExpressionDefinitionRoot/ExpressionDefinitionLogicTypeSelector.tsx:
##########
@@ -147,9 +147,7 @@ export function ExpressionDefinitionLogicTypeSelector({
case "context":
return <ContextExpression expression={expression} isNested={isNested}
parentElementId={parentElementId} />;
case "decisionTable":
- return (
- <DecisionTableExpression expression={expression} isNested={isNested}
parentElementId={parentElementId} />
- );
+ return <DecisionTableExpression expression={expression}
isNested={isNested} />;
Review Comment:
Why remove the parentElementId?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
