fantonangeli commented on code in PR #2478:
URL:
https://github.com/apache/incubator-kie-tools/pull/2478#discussion_r1705130966
##########
packages/runtime-tools-swf-enveloped-components/src/workflowDefinitions/envelope/components/WorkflowDefinitionListToolbar/WorkflowDefinitionListToolbar.tsx:
##########
@@ -109,6 +109,7 @@ const WorkflowDefinitionListToolbar:
React.FC<WorkflowDefinitionListToolbarProps
onKeyPress={onEnterClicked}
placeholder={`Filter by workflow name`}
value={workflowNameInput}
+ data-testid="workflowFilterInput"
Review Comment:
Extra small suggestion to follow the repository style for `data-testid`
```suggestion
data-testid="workflow-filter-input"
```
##########
packages/runtime-tools-swf-enveloped-components/tests/components/WorkflowDefinitionList.test.tsx:
##########
@@ -76,7 +77,7 @@ describe("WorkflowDefinitionList component", () => {
expect(component.queryByText("Test Workflow 1")).toBeInTheDocument();
expect(component.queryByText("Test Workflow 2")).toBeInTheDocument();
- fireEvent.change(component.getByPlaceholderText("Filter by workflow
name"), {
+ fireEvent.change(component.getByTestId("workflowFilterInput"), {
Review Comment:
```suggestion
fireEvent.change(component.getByTestId("workflow-filter-input"), {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
