danielzhe commented on PR #2527: URL: https://github.com/apache/incubator-kie-tools/pull/2527#issuecomment-2286735029
> So there's this "containerElement" method you added to some of the expression types, but I'm not sure it's a good idea to expose it as a "public" getter, since this "containerElement" is not really a visual thing we can differentiate on-screen. Not sure how to proceed, but wanted to mention that to see if you can try and find an alternative... As reading the tests that contain calls to this new "containerElement" is not 100% clear to me. Thanks! I made some changes to this. It is more clear now. We can still call the element which contains the expression, but now it is called `elementCell` which is the `cell` that contains the element. Also now we can call `hover()` directly in the expressions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
