fantonangeli commented on code in PR #2537:
URL:
https://github.com/apache/incubator-kie-tools/pull/2537#discussion_r1722094553
##########
packages/sonataflow-deployment-webapp/src/navigation/RoutesSwitch.tsx:
##########
@@ -38,6 +47,7 @@ export function RoutesSwitch() {
</Route>
<Route path={routes.workflows.home.path({})}>
<Workflows />
+ {/* <RuntimeToolsWorkflowDefinitions /> */}
</Route>
Review Comment:
We can move this block to `src/navigation/RuntimeToolsRoutesSwitch.tsx`
rendering `RuntimeToolsWorkflowDefinitions` instead of `Workflows`
##########
packages/sonataflow-deployment-webapp/src/pages/Workflows/Workflows.tsx:
##########
Review Comment:
We don't need this file anymore as we can use
`src/runtimeTools/pages/RuntimeToolsWorkflowDefinitions.tsx` directly
##########
packages/sonataflow-deployment-webapp/src/navigation/RoutesSwitch.tsx:
##########
@@ -26,10 +26,19 @@ import { CloudEventFormPage } from
"../pages/Workflows/CloudEventFormPage";
import { WorkflowFormPage } from "../pages/Workflows/WorkflowFormPage";
import { routes } from "../routes";
import { RuntimeToolsRoutesSwitch } from "./RuntimeToolsRoutesSwitch";
+import { RuntimeToolsWorkflowInstances } from
"../runtimeTools/pages/RuntimeToolsWorkflowInstances";
+import { RuntimeToolsWorkflowDetails } from
"../runtimeTools/pages/RuntimeToolsWorkflowDetails";
+import { RuntimeToolsWorkflowDefinitions } from
"../runtimeTools/pages/RuntimeToolsWorkflowDefinitions";
export function RoutesSwitch() {
return (
<Switch>
+ <Route path={routes.runtimeTools.workflowInstances.path({})}>
+ <RuntimeToolsWorkflowInstances />
+ </Route>
+ <Route path={routes.runtimeTools.workflowDetails.path({ workflowId:
":workflowId" })}>
+ {({ match }) => <RuntimeToolsWorkflowDetails
workflowId={match!.params.workflowId!} />}
+ </Route>
Review Comment:
These switches should be defined in
`src/navigation/RuntimeToolsRoutesSwitch.tsx`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
