tkobayas commented on PR #6042: URL: https://github.com/apache/incubator-kie-drools/pull/6042#issuecomment-2300276935
Hi @Rashmesh , thank you for the PR. I see that this PR does: - Call `ksession.dispose()` - Change `List` to `List<String>` Both are totally valid and better coding, but I wonder if we will take this kind of PR per test method. Probably you are aware that many test cases in this project have similar room to improvement. I would be great to improve them at once e.g. using a shell script or OpenRewrite (https://docs.openrewrite.org/). If manual intervention is required, hmm, at least PR per test class would be nice? I'm not asking you to do that now. Just thinking out loud... Any thoughts? > @pibizza @mariofusco -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
