Abhitocode opened a new pull request, #3651:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3651

   Below are the tests with issues, commented the same for each test.
   
   1. ActivityTest.java
   - **testErrorBetweenProcessesProcess**
   The execution fails with a java.lang.NullPointerException at the line where 
we create an instance of my process (process.createInstance(model)), indicating 
that Processes.processById(String) is returning null. Also getting an 
org.opentest4j.AssertionFailedError, where the expected value is 2, but the 
actual value is 5.
   
   java.lang.NullPointerException: Cannot invoke 
"org.kie.kogito.process.Process.createInstance(org.kie.kogito.Model)" because 
the return value of "org.kie.kogito.process.Processes.processById(String)" is 
null
   org.opentest4j.AssertionFailedError: 
   expected: 2
    but was: 5
   
   - **testUserTaskWithAssignment**
   process() method from the AbstractProcess class is protected , hence not 
able to access it.
   error: WorkflowProcess workflowProcess = ((AbstractProcess<?>) 
process).process();
   process()' has protected access in 
'org.kie.kogito.process.impl.AbstractProcess'
   
   2. CompensationTest
   
   - compensationInSubSubProcesses
   It appears there are a few nodes that are missing outbound or inbound 
connections. The BPMN editor didn't indicate any problems, but it turns out 
that these nodes have no connection to the start node.
   
   error:
   java.lang.IllegalStateException: Process could not be validated ![Process 
'Default Process' [InSubSubProcess]: Node 'Boundary Compensate 3' [_X-1] Event 
has no outgoing connection
           Process 'Default Process' [InSubSubProcess]: Node 'Compensate 
Handler 3' [_X-2] Action has no incoming connection.,
           Process 'Default Process' [InSubSubProcess]: Node 'Boundary 
Compensate 2' [_Y-1] Event has no outgoing connection,
           Process 'Default Process' [InSubSubProcess]: Node 'Compensate 
Handler 2' [_Y-2] Action has no incoming connection.,
           Process 'Default Process' [InSubSubProcess]: Node 'Compensate 
Handler 3' [_X-2] Has no connection to the start node.,
           Process 'Default Process' [InSubSubProcess]: Node 'Compensate 
Handler 2' [_Y-2] Has no connection to the start node.]*
   
   DataTest-33
   - testDataStore and testAssociation
   When compiling the code, we cannot resolve method 'metaData' in 'Process'.
   As I understand, the metaData() method is protected, and thus, it isn't 
directly accessible in the test class.
   How to get process metadata from the process object(only then we can get the 
definition metadata).
   
   - testDefaultProcessVariableValue 
   CorrelationKeyModel does not have methods named getProcVar and getIntVar .
   This may be due to acutal variables/methods being different in the 
CorrelationKeyModel.
   
   guidance on aobe would be helpful.
   
   
   Note: This pr contains tests with error, only for review purpose.
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to