pefernan commented on code in PR #2536:
URL:
https://github.com/apache/incubator-kie-tools/pull/2536#discussion_r1741886581
##########
packages/jbpm-quarkus-devui/jbpm-quarkus-devui-deployment/src/main/java/org/jbpm/quarkus/devui/deployment/DevConsoleProcessor.java:
##########
@@ -112,19 +114,21 @@ public CardPageBuildItem pages(
String uiPath =
nonApplicationRootPathBuildItem.resolveManagementPath(BASE_RELATIVE_URL,
managementInterfaceBuildTimeConfig, launchModeBuildItem, true);
- String openapiPath = getProperty(configurationBuildItem,
systemPropertyBuildItems, "quarkus.smallrye-openapi.path");
String devUIUrl = getProperty(configurationBuildItem,
systemPropertyBuildItems, "kogito.dev-ui.url");
- String dataIndexUrl = getProperty(configurationBuildItem,
systemPropertyBuildItems, "kogito.data-index.url");
+ String dataIndexUrl = getProperty(configurationBuildItem,
systemPropertyBuildItems, "kogito.dataindex.http.url");
Review Comment:
@thiagoelg @tiagobento sorry for being late here, I missed this while on PTO.
This System property (`kogito.data-index.url`) is the one that was set by
default by the Runtime Dev Services if it starts the Embedded Data-Index and
this same property is set by default by the Data Index Addon if present. So
that's why I made the DevProcesor use it.
The `kogito.dataindex.http.url` as far as I know is a config property that
is being used by certain components (So far I only found the SVG addon) to
build WebClients to interact with Data Index or in IT Tests. IDK if it has any
other internal usage.
In this particular case I'd keep using the original property
(`kogito.data-index.url`) but I think it would be worth checking if we could
consolidate the usage of the data-index url in a single system property instead
of having two of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
