fantonangeli commented on code in PR #2608:
URL:
https://github.com/apache/incubator-kie-tools/pull/2608#discussion_r1771161011
##########
packages/serverless-logic-web-tools/src/settings/runtimeTools/RuntimeToolsSettings.tsx:
##########
@@ -60,10 +62,12 @@ export function RuntimeToolsSettings(props:
SettingsPageProps) {
const settingsDispatch = useSettingsDispatch();
const [config, setConfig] = useState(settings.runtimeTools.config);
const [isModalOpen, setIsModalOpen] = useState(false);
- const [isDataIndexUrlValidated, setDataIndexUrlValidated] =
useState(DataIndexValidation.INVALID);
+ const [isDataIndexUrlValidated, setDataIndexUrlValidated] =
useState(FormValiationOptions.INITIAL);
+ const [isDataIndexUrlVerified, setisDataIndexUrlVerified] =
useState(FormValiationOptions.INITIAL);
Review Comment:
Similarily to
https://github.com/kumaradityaraj/kie-tools/blob/2709ce4349c467ffba41e2e8f9cbe78c10502333/packages/serverless-logic-web-tools/src/settings/openshift/OpenShiftSettingsSimpleConfig.tsx#L58
Can we use one state, for the validation result?
```suggestion
const [isConfigValidated, setConfigValidated] =
useState(FormValiationOptions.INITIAL);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
