mariofusco commented on code in PR #6097:
URL:
https://github.com/apache/incubator-kie-drools/pull/6097#discussion_r1772789518
##########
drools-decisiontables/src/main/java/org/drools/decisiontable/DecisionTableProviderImpl.java:
##########
@@ -42,16 +42,16 @@ public class DecisionTableProviderImpl
implements
DecisionTableProvider {
- private static final transient Logger logger = LoggerFactory.getLogger(
DecisionTableProviderImpl.class );
+ private static final Logger logger = LoggerFactory.getLogger(
DecisionTableProviderImpl.class );
+
+ private Map<String, String> compiledDtablesCache = new HashMap<>();
Review Comment:
I guess you're right. In reality I was thinking to it yesterday when I wrote
that code, and I decided that we don't have any situation when we do 2 dtable
-> drl conversions in parallel, but I was not properly considering that this is
a singleton indeed. Better to play on the safe side on this. I will turn it
into a `ConcurrentHashMap`, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
