gitgabrio commented on code in PR #3686:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3686#discussion_r1796665446
##########
kogito-codegen-modules/kogito-codegen-processes/src/main/java/org/kie/kogito/codegen/process/StaticDependencyInjectionProducerGenerator.java:
##########
@@ -58,6 +58,20 @@ public Map<String, String> generate() {
generator ->
generator.compilationUnitOrThrow().toString()));
}
+ /**
+ * Key is the FilePath, Value is the content
+ *
+ * @return Map with the generated resources
+ */
+ public Map<String, String> generate(String... templates) {
Review Comment:
This is method is a duplication of
`public Map<String, String> generate() `
Please, unify them, e.g.
` generate() `-> `generate(producerTemplates)` (you have to adjust list ->
varargs)
##########
kogito-codegen-modules/kogito-codegen-processes/src/main/java/org/kie/kogito/codegen/process/StaticDependencyInjectionProducerGenerator.java:
##########
@@ -58,6 +58,20 @@ public Map<String, String> generate() {
generator ->
generator.compilationUnitOrThrow().toString()));
}
+ /**
+ * Key is the FilePath, Value is the content
+ *
+ * @return Map with the generated resources
+ */
+ public Map<String, String> generate(String... templates) {
Review Comment:
This method is a duplication of
`public Map<String, String> generate() `
Please, unify them, e.g.
` generate() `-> `generate(producerTemplates)` (you have to adjust list ->
varargs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
