tiagobento commented on code in PR #2716:
URL:
https://github.com/apache/incubator-kie-tools/pull/2716#discussion_r1823004259
##########
packages/dev-deployment-kogito-quarkus-blank-app/pom.xml:
##########
@@ -94,6 +92,16 @@
</dependencyManagement>
<dependencies>
+ <dependency>
+ <groupId>com.google.protobuf</groupId>
+ <artifactId>protobuf-java</artifactId>
+ <version>${version.com.google.protobuf}</version>
+ </dependency>
+ <dependency>
+ <groupId>com.google.protobuf</groupId>
+ <artifactId>protobuf-java-util</artifactId>
+ <version>${version.com.google.protobuf}</version>
+ </dependency>
Review Comment:
Can you please add a comment here with a disclaimer that those dependencies
are only here to force this application to use a newer version of these
dependencies? This will help not having people thinking this is necessary for
the app to function properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
