martinweiler commented on code in PR #3788:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3788#discussion_r1851035882
##########
jbpm/jbpm-flow/src/main/java/org/jbpm/process/core/timer/BusinessCalendarImpl.java:
##########
@@ -90,15 +90,14 @@ public class BusinessCalendarImpl implements
BusinessCalendar {
private List<TimePeriod> holidays;
private List<Integer> weekendDays = new ArrayList<>();
private SessionClock clock;
+ private final StringBuilder errorMessage = new StringBuilder();
private static final int SIM_WEEK = 3;
private static final int SIM_DAY = 5;
private static final int SIM_HOU = 7;
private static final int SIM_MIN = 9;
private static final int SIM_SEC = 11;
- public static final String DAYS_PER_WEEK = "business.days.per.week";
- public static final String HOURS_PER_DAY = "business.hours.per.day";
Review Comment:
Make sure the javadoc of this class is in-line with these changes (removed
properties, removed default values)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
