jomarko commented on code in PR #6167: URL: https://github.com/apache/incubator-kie-drools/pull/6167#discussion_r1851713831
########## .rat-excludes: ########## @@ -0,0 +1,46 @@ +\.rat-excludes +\.gitignore +DISCLAIMER-WIP +LICENSE-.*\.txt Review Comment: I think we do not have such file `LICENSE-.*\.txt` ########## .rat-excludes: ########## @@ -0,0 +1,46 @@ +\.rat-excludes +\.gitignore +DISCLAIMER-WIP +LICENSE-.*\.txt +ui-bundle\.zip +\.git-blame-ignore-revs +dependency-reduced-pom\.xml +lunr-2\.3\.9\.min\.js +search-ui\.js +search\.css +branch\.yaml +main\.yaml +mvel\.jj +JavaLexer\.g4 +JavaParser\.g4 +.*\.csv +.*\.sdo +.*\.sdt +TestingEmptyFile\.txt +.*\.test_json +.*\.pmml_json +.*\.drl_json +.*\.dslr +.*DMN.*\.xsd +dmn.xsd Review Comment: I thought `dmn.xsd` is developed as part of KIE community, shouldn't we keep license header for it? I do not see a link for such file on the OMG website.  ########## NOTICE: ########## @@ -5,19 +5,9 @@ This product includes software developed at The Apache Software Foundation (http://www.apache.org/). The Initial Developer of some parts of the framework, which are copied from, derived from, or -inspired by KIE (Knowledge Is Everthing) group, is Red Hat, Inc (https://www.redhat.com/). +inspired by KIE (Knowledge Is Everything) group, is Red Hat, Inc (https://www.redhat.com/). Copyright Red Hat, Inc. and/or its affiliates.. All Rights Reserved. -This product also includes the following third-party components: - -* lunr 2.3.9 - Downloaded from: https://lunrjs.com/ - License: MIT - -* search-ui - Downloaded from: https://gitlab.com/antora/antora-lunr-extension - License: Mozilla Public License 2.0 - -* antora ui-bundle - Downloaded from: https://github.com/stephengold/antora-ui-bundle - License: Mozilla Public License 2.0 Review Comment: I think we need to add corresponding entries into LICENSE file, as the files are still delivered as part of `apache-kie-10.0.0-incubating-sources.zip`. ########## .rat-excludes: ########## @@ -0,0 +1,46 @@ +\.rat-excludes +\.gitignore +DISCLAIMER-WIP +LICENSE-.*\.txt +ui-bundle\.zip +\.git-blame-ignore-revs +dependency-reduced-pom\.xml +lunr-2\.3\.9\.min\.js +search-ui\.js +search\.css +branch\.yaml +main\.yaml +mvel\.jj +JavaLexer\.g4 +JavaParser\.g4 Review Comment: I think we do not have files with `g4` extension ########## .rat-excludes: ########## @@ -0,0 +1,46 @@ +\.rat-excludes +\.gitignore +DISCLAIMER-WIP +LICENSE-.*\.txt +ui-bundle\.zip +\.git-blame-ignore-revs +dependency-reduced-pom\.xml +lunr-2\.3\.9\.min\.js +search-ui\.js +search\.css +branch\.yaml +main\.yaml +mvel\.jj +JavaLexer\.g4 +JavaParser\.g4 +.*\.csv +.*\.sdo +.*\.sdt +TestingEmptyFile\.txt +.*\.test_json +.*\.pmml_json +.*\.drl_json +.*\.dslr +.*DMN.*\.xsd +dmn.xsd +DC\.xsd +DI\.xsd +KiePMML.*\.txt +TargetValueFactoryTest_01\.txt +TargetFieldFactoryTest_01\.txt +.*\.uml +drools-model +testFile\.txt +simple\.dot +.*\.log +.*\.lst +checkstyle-cachefile +test.*\.txt +test.*\.yml +drl\.ftl +goal\.txt +adult\.txt +antora\.yml +.*\.iml +CsvLineParser\.java +target/* Review Comment: Reading the comment [here](https://github.com/apache/incubator-kie-tools/pull/2746#discussion_r1849492240), I thought `target/*` is not valid, but probably it is? Running rat tool locally didn't complain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
