tkobayas commented on code in PR #6174: URL: https://github.com/apache/incubator-kie-drools/pull/6174#discussion_r1860230610
########## LICENSE: ########## @@ -381,6 +381,283 @@ event that testing suites are implemented or approved by Object Management Group specification may claim compliance or conformance with the specification only if the software satisfactorily completes the testing suites. - ------------------------------------------------------------------------------------ - for drools-model/drools-mvel-parser/src/main/javacc/mvel.jj - JavaParser is dual licensed under LGPL license and Apache License Version 2.0 license. We choose the Apache License Version 2.0. +------------------------------------------------------------------------------------ +for drools-model/drools-mvel-parser/src/main/javacc/mvel.jj + JavaParser is dual licensed under LGPL license and Apache License Version 2.0 license. We choose the Apache License Version 2.0. + +------------------------------------------------------------------------------------ +for drools-model/drools-canonical-model/src/main/java/org/drools/model/bitmask/OpenBitSet.java + drools-util/src/main/java/org/drools/util/bitmask/OpenBitSet.java Review Comment: Sorry that I didn't provide the information first. https://github.com/apache/incubator-kie-drools/blob/main/drools-model/drools-canonical-model/src/main/java/org/drools/model/bitmask/OpenBitSet.java#L901-L919 ``` * NOTE: this was originally borrowed from Python 2.4.2 * listobject.c sources (attribution in LICENSE.txt), but * has now been substantially changed based on * discussions from java-dev thread with subject "Dynamic * array reallocation algorithms", started on Jan 12 * 2010. ``` I'm not sure how we should treat "borrowed" and "substantially changed" and it's just one method of the class. @pjfanning Do we need to list this file as Python Software Foundation License? (although this is not urgent --- PSF is Category A) > is the whole history of Python really part of the license? It's the content of the LICENSE. https://github.com/python/cpython/blob/main/LICENSE @pjfanning If we can drop the "history" part, please let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
