jomarko commented on issue #1645:
URL: 
https://github.com/apache/incubator-kie-issues/issues/1645#issuecomment-2505261561

   Hi @kanetran 
   
   1. yes, latest sandbox webapp uses DMN 1.5
   2. static analysis just report found issues, I think it reports some valid 
issues [1]
   3. where do you read this about `?` please, see also my points [1]
   4. You can turn off `extended-services`, that will stop the static analysis, 
however also the `DMN Runner` will be disabled in such case, basically the 
feature under `Run` button will be disabled
   
   One more general comment about DRL vs DMN. They are similar, but different.
   
   1. DMN Can not update an object, only construct a new one.
   2. Your DRL will automatically try to match agains all possible pairs of 
`ProductPricing` and `SubscriptionPricingModel` while the DMN function will try 
to match against single pair of `ProductPricing` and `SubscriptionPricingModel`.
   
   [1]
   1. the question mark is not needed in your decision table, please use `>= 
date and time(2023,10,1,0,0,0)`
   2. `not` takes as an argument boolean while you pass a string, so you can 
replace your `not` with a unary test like `!= pp.promotionCode`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to