danielzhe commented on PR #2760: URL: https://github.com/apache/incubator-kie-tools/pull/2760#issuecomment-2506723527
Thank you for your review, @jomarko ! About the points you commented: 1. I made a new screen with a X in the top corner, where we can cancel the change, like discussed in the private chat. Here is the print:  2. Change applied. Decision tables should be working now 3. ok 4. That field is not "expression aware", it is just a text box. We have two tickets to address that, so it is not covered in this: a. https://github.com/apache/incubator-kie-issues/issues/205 b. https://github.com/apache/incubator-kie-issues/issues/276 5. As discussed in private chat, that is something that depends on user. We can't (shouldn't) not allow the user to rename it if the name is duplicated. It is up to the user. Once the parameters have duplicated names, there is no way for us to know which one is which inside the expression. 6. No, we don't have. We had a discussion about this and we come to idea to add the confirmation dialog instead an option to disable/enable it, remember? I didn't found out any slow down using the feature. If you can provide some reproducible steps, we can check it. 7. ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
