fjtirado commented on code in PR #2161:
URL: 
https://github.com/apache/incubator-kie-kogito-apps/pull/2161#discussion_r1882472997


##########
data-index/data-index-storage/data-index-storage-postgresql/src/test/java/org/kie/kogito/index/postgresql/query/ProcessInstanceEntityQueryIT.java:
##########
@@ -18,13 +18,103 @@
  */
 package org.kie.kogito.index.postgresql.query;
 
+import java.util.List;
+import java.util.UUID;
+
+import org.junit.jupiter.api.Test;
+import org.kie.kogito.event.process.ProcessInstanceVariableDataEvent;
 import org.kie.kogito.index.jpa.query.AbstractProcessInstanceEntityQueryIT;
+import org.kie.kogito.index.storage.ProcessInstanceStorage;
+import org.kie.kogito.index.test.TestUtils;
 import org.kie.kogito.testcontainers.quarkus.PostgreSqlQuarkusTestResource;
 
 import io.quarkus.test.common.QuarkusTestResource;
 import io.quarkus.test.junit.QuarkusTest;
 
+import static java.util.Collections.singletonList;
+import static org.kie.kogito.index.json.JsonUtils.jsonFilter;
+import static org.kie.kogito.index.test.QueryTestUtils.assertNotId;
+import static org.kie.kogito.index.test.QueryTestUtils.assertWithId;
+import static org.kie.kogito.persistence.api.query.QueryFilterFactory.*;
+
 @QuarkusTest
 @QuarkusTestResource(PostgreSqlQuarkusTestResource.class)
 class ProcessInstanceEntityQueryIT extends 
AbstractProcessInstanceEntityQueryIT {
+
+    @Test
+    void testProcessInstanceVariables() {
+        String processId = "travels";
+        String processInstanceId = UUID.randomUUID().toString();
+        ProcessInstanceStorage storage = getStorage();
+        ProcessInstanceVariableDataEvent variableEvent = 
TestUtils.createProcessInstanceVariableEvent(processInstanceId, processId, 
"John", 28, false,
+                List.of("Super", "Astonishing", "TheRealThing"));
+        storage.indexVariable(variableEvent);
+        queryAndAssert(assertWithId(), storage, 
singletonList(jsonFilter(equalTo("variables.traveller.name", "John"))), null, 
null, null,
+                processInstanceId);
+        queryAndAssert(assertNotId(), storage, 
singletonList(jsonFilter(equalTo("variables.traveller.name", "Smith"))), null, 
null, null,
+                processInstanceId);
+        queryAndAssert(assertWithId(), storage, 
singletonList(jsonFilter(equalTo("variables.traveller.isMartian", false))), 
null, null, null,
+                processInstanceId);
+        queryAndAssert(assertNotId(), storage, 
singletonList(jsonFilter(equalTo("variables.traveller.isMartian", true))), 
null, null, null,
+                processInstanceId);
+        queryAndAssert(assertWithId(), storage, 
singletonList(jsonFilter(equalTo("variables.traveller.age", 28))), null, null, 
null,
+                processInstanceId);
+        queryAndAssert(assertNotId(), storage, 
singletonList(jsonFilter(equalTo("variables.traveller.age", 29))), null, null, 
null,
+                processInstanceId);
+        queryAndAssert(assertWithId(), storage, 
singletonList(jsonFilter(between("variables.traveller.age", 26, 30))), null, 
null, null,
+                processInstanceId);
+        queryAndAssert(assertNotId(), storage, 
singletonList(jsonFilter(between("variables.traveller.age", 1, 3))), null, 
null, null,
+                processInstanceId);
+        queryAndAssert(assertWithId(), storage, 
singletonList(jsonFilter(between("variables.traveller.age", 26, 30))), null, 
null, null,
+                processInstanceId);
+        queryAndAssert(assertNotId(), storage, 
singletonList(jsonFilter(between("variables.traveller.age", 1, 3))), null, 
null, null,
+                processInstanceId);
+        queryAndAssert(assertWithId(), storage, 
singletonList(jsonFilter(greaterThan("variables.traveller.age", 26))), null, 
null, null,
+                processInstanceId);
+        queryAndAssert(assertNotId(), storage, 
singletonList(jsonFilter(greaterThan("variables.traveller.age", 28))), null, 
null, null,
+                processInstanceId);
+        queryAndAssert(assertWithId(), storage, 
singletonList(jsonFilter(greaterThanEqual("variables.traveller.age", 28))), 
null, null, null,
+                processInstanceId);
+        queryAndAssert(assertNotId(), storage, 
singletonList(jsonFilter(greaterThanEqual("variables.traveller.age", 29))), 
null, null, null,
+                processInstanceId);
+        queryAndAssert(assertWithId(), storage, 
singletonList(jsonFilter(lessThan("variables.traveller.age", 29))), null, null, 
null,
+                processInstanceId);
+        queryAndAssert(assertNotId(), storage, 
singletonList(jsonFilter(lessThan("variables.traveller.age", 28))), null, null, 
null,
+                processInstanceId);
+        queryAndAssert(assertWithId(), storage, 
singletonList(jsonFilter(lessThanEqual("variables.traveller.age", 28))), null, 
null, null,
+                processInstanceId);
+        queryAndAssert(assertNotId(), storage, 
singletonList(jsonFilter(lessThanEqual("variables.traveller.age", 27))), null, 
null, null,
+                processInstanceId);
+        queryAndAssert(assertWithId(), storage, 
singletonList(jsonFilter(lessThanEqual("variables.traveller.age", 28))), null, 
null, null,
+                processInstanceId);
+        queryAndAssert(assertNotId(), storage, 
singletonList(jsonFilter(lessThanEqual("variables.traveller.age", 27))), null, 
null, null,
+                processInstanceId);
+        queryAndAssert(assertWithId(), storage, 
singletonList(jsonFilter(in("variables.traveller.name", List.of("John", 
"Smith")))), null, null, null,
+                processInstanceId);
+        queryAndAssert(assertNotId(), storage, 
singletonList(jsonFilter(in("variables.traveller.age", List.of("Jack", 
"Smith")))), null, null, null,
+                processInstanceId);
+        queryAndAssert(assertWithId(), storage, 
singletonList(jsonFilter(in("variables.traveller.age", List.of(28, 29)))), 
null, null, null,
+                processInstanceId);
+        queryAndAssert(assertNotId(), storage, 
singletonList(jsonFilter(in("variables.traveller.age", List.of(27, 29)))), 
null, null, null,
+                processInstanceId);
+        queryAndAssert(assertWithId(), storage, 
singletonList(jsonFilter(like("variables.traveller.name", "Joh*"))), null, 
null, null,
+                processInstanceId);
+        queryAndAssert(assertNotId(), storage, 
singletonList(jsonFilter(like("variables.traveller.name", "Joha*"))), null, 
null, null,
+                processInstanceId);
+        queryAndAssert(assertWithId(), storage, 
singletonList(jsonFilter(notNull("variables.traveller.aliases"))), null, null, 
null,
+                processInstanceId);
+        queryAndAssert(assertNotId(), storage, 
singletonList(jsonFilter(isNull("variables.traveller.aliases"))), null, null, 
null,
+                processInstanceId);
+        queryAndAssert(assertWithId(), storage, 
singletonList(not(jsonFilter(isNull("variables.traveller.aliases")))), null, 
null, null,
+                processInstanceId);
+        queryAndAssert(assertWithId(), storage, 
singletonList(and(List.of(jsonFilter(notNull("variables.traveller.aliases")), 
jsonFilter(lessThan("variables.traveller.age", 45))))), null, null, null,
+                processInstanceId);
+        queryAndAssert(assertWithId(), storage, 
singletonList(or(List.of(jsonFilter(notNull("variables.traveller.aliases")), 
jsonFilter(lessThan("variables.traveller.age", 22))))), null, null, null,
+                processInstanceId);
+        // TODO add support for json contains (requires writing dialect 
extension on hibernate)

Review Comment:
   This will be uncommented with 
https://github.com/apache/incubator-kie-kogito-apps/issues/2163



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to