pefernan commented on code in PR #3665:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3665#discussion_r1884056509


##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/ActivityTest.java:
##########
@@ -1497,20 +1501,26 @@ public void testServiceTaskWithMvelJaxbTransformation() 
throws Exception {
     }
 
     @Test
-    public void testErrorBetweenProcessesProcess() throws Exception {
-        kruntime = 
createKogitoProcessRuntime("org/jbpm/bpmn2/subprocess/BPMN2-ErrorsBetweenProcess.bpmn2",
-                
"org/jbpm/bpmn2/subprocess/BPMN2-ErrorsBetweenSubProcess.bpmn2");
-
-        Map<String, Object> variables = new HashMap<>();
-
-        variables.put("tipoEvento", "error");
-        variables.put("pasoVariable", 3);
-        KogitoProcessInstance processInstance = 
kruntime.startProcess("ErrorsBetweenProcess", variables);
-
-        assertProcessInstanceCompleted(processInstance.getStringId(), 
kruntime);
-        assertProcessInstanceAborted(processInstance.getStringId() + 1, 
kruntime);
+    public void testErrorBetweenProcessesProcess() {
+        Application app = ProcessTestHelper.newApplication();
+        ProcessTestHelper.registerProcessEventListener(app, new 
DefaultKogitoProcessEventListener() {
+            @Override
+            public void afterProcessCompleted(ProcessCompletedEvent event) {
+                if 
("ErrorsBetweenSubProcess".equals(event.getProcessInstance().getProcessId())) {
+                    
assertThat(event.getProcessInstance().getState()).isEqualTo(ProcessInstance.STATE_ABORTED);
+                }
+            }
+        });
+        ErrorsBetweenSubProcessProcess.newProcess(app);
+        org.kie.kogito.process.Process<ErrorsBetweenProcessModel> process = 
ErrorsBetweenProcessProcess.newProcess(app);
+        ErrorsBetweenProcessModel model = process.createModel();
+        model.setTipoEvento("error");
+        model.setPasoVariable(3);
+        ProcessInstance<ErrorsBetweenProcessModel> processInstance = 
process.createInstance(model);
+        processInstance.start();
+        
assertThat(processInstance.status()).isEqualTo(ProcessInstance.STATE_COMPLETED);
 
-        assertProcessVarValue(processInstance, "event", "error desde 
Subproceso");
+        Assertions.assertEquals("error desde Subproceso", 
processInstance.variables().getEvent());

Review Comment:
   please use Assertj here :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to