jomarko commented on code in PR #2819:
URL:
https://github.com/apache/incubator-kie-tools/pull/2819#discussion_r1889845483
##########
packages/dev-deployment-kogito-quarkus-blank-app/pom.xml:
##########
@@ -41,19 +41,18 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
- <!-- Maven versions -->
- <version.maven.artifact.plugin>3.4.1</version.maven.artifact.plugin>
+ <!-- Plugins version -->
+ <version.codehaus.flatten.plugin>1.6.0</version.codehaus.flatten.plugin>
+ <version.maven.clean.plugin>3.4.0</version.maven.clean.plugin>
<version.maven.compiler.plugin>3.13.0</version.maven.compiler.plugin>
- <version.maven.resources.plugin>3.3.1</version.maven.resources.plugin>
- <version.maven.failsafe.plugin>3.0.0-M7</version.maven.failsafe.plugin>
- <version.maven.surefire.plugin>3.5.0</version.maven.surefire.plugin>
- <version.maven.install.plugin>3.1.3</version.maven.install.plugin>
+ <version.maven.dependency.plugin>3.7.1</version.maven.dependency.plugin>
<version.maven.deploy.plugin>3.1.2</version.maven.deploy.plugin>
Review Comment:
version.maven.deploy.plugin seems to be unused
##########
packages/stunner-editors/pom.xml:
##########
@@ -187,29 +187,29 @@
<version.antrun.plugin>1.8</version.antrun.plugin>
<version.buildhelper.plugin>3.0.0</version.buildhelper.plugin>
<version.bundle.plugin>3.3.0</version.bundle.plugin>
- <version.checkstyle.plugin>3.2.0</version.checkstyle.plugin>
- <version.clean.plugin>3.1.0</version.clean.plugin>
- <version.compiler.plugin>3.12.1</version.compiler.plugin>
- <version.dependency.plugin>3.3.0</version.dependency.plugin>
- <version.deploy.plugin>2.8.2</version.deploy.plugin>
- <version.enforcer.plugin>3.1.0</version.enforcer.plugin>
+ <version.checkstyle.plugin>3.4.0</version.checkstyle.plugin>
Review Comment:
is expected dashbuilder overrides to 3.1.1? I think preferred would be
single version everywhere if possible
##########
packages/dev-deployment-kogito-quarkus-blank-app/pom.xml:
##########
@@ -41,19 +41,18 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
- <!-- Maven versions -->
- <version.maven.artifact.plugin>3.4.1</version.maven.artifact.plugin>
+ <!-- Plugins version -->
+ <version.codehaus.flatten.plugin>1.6.0</version.codehaus.flatten.plugin>
+ <version.maven.clean.plugin>3.4.0</version.maven.clean.plugin>
<version.maven.compiler.plugin>3.13.0</version.maven.compiler.plugin>
- <version.maven.resources.plugin>3.3.1</version.maven.resources.plugin>
- <version.maven.failsafe.plugin>3.0.0-M7</version.maven.failsafe.plugin>
- <version.maven.surefire.plugin>3.5.0</version.maven.surefire.plugin>
- <version.maven.install.plugin>3.1.3</version.maven.install.plugin>
+ <version.maven.dependency.plugin>3.7.1</version.maven.dependency.plugin>
<version.maven.deploy.plugin>3.1.2</version.maven.deploy.plugin>
+
<version.maven.failsafe.plugin>${version.maven.surefire.plugin}</version.maven.failsafe.plugin>
Review Comment:
hm, this sounds a little bit non-standard to me, is that intentional to
combine failsafe and surefire versions? furthermore
version.maven.failsafe.plugin seems to be unused
##########
packages/stunner-editors/pom.xml:
##########
@@ -187,29 +187,29 @@
<version.antrun.plugin>1.8</version.antrun.plugin>
<version.buildhelper.plugin>3.0.0</version.buildhelper.plugin>
<version.bundle.plugin>3.3.0</version.bundle.plugin>
- <version.checkstyle.plugin>3.2.0</version.checkstyle.plugin>
- <version.clean.plugin>3.1.0</version.clean.plugin>
- <version.compiler.plugin>3.12.1</version.compiler.plugin>
- <version.dependency.plugin>3.3.0</version.dependency.plugin>
- <version.deploy.plugin>2.8.2</version.deploy.plugin>
- <version.enforcer.plugin>3.1.0</version.enforcer.plugin>
+ <version.checkstyle.plugin>3.4.0</version.checkstyle.plugin>
+ <version.clean.plugin>3.4.0</version.clean.plugin>
+ <version.compiler.plugin>3.13.0</version.compiler.plugin>
Review Comment:
same comment as above
##########
packages/dev-deployment-kogito-quarkus-blank-app/pom.xml:
##########
@@ -41,19 +41,18 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
- <!-- Maven versions -->
- <version.maven.artifact.plugin>3.4.1</version.maven.artifact.plugin>
+ <!-- Plugins version -->
+ <version.codehaus.flatten.plugin>1.6.0</version.codehaus.flatten.plugin>
+ <version.maven.clean.plugin>3.4.0</version.maven.clean.plugin>
<version.maven.compiler.plugin>3.13.0</version.maven.compiler.plugin>
- <version.maven.resources.plugin>3.3.1</version.maven.resources.plugin>
- <version.maven.failsafe.plugin>3.0.0-M7</version.maven.failsafe.plugin>
- <version.maven.surefire.plugin>3.5.0</version.maven.surefire.plugin>
- <version.maven.install.plugin>3.1.3</version.maven.install.plugin>
+ <version.maven.dependency.plugin>3.7.1</version.maven.dependency.plugin>
Review Comment:
seems as unused?
<version.maven.dependency.plugin>3.7.1</version.maven.dependency.plugin>
##########
packages/stunner-editors/pom.xml:
##########
@@ -187,29 +187,29 @@
<version.antrun.plugin>1.8</version.antrun.plugin>
<version.buildhelper.plugin>3.0.0</version.buildhelper.plugin>
<version.bundle.plugin>3.3.0</version.bundle.plugin>
- <version.checkstyle.plugin>3.2.0</version.checkstyle.plugin>
- <version.clean.plugin>3.1.0</version.clean.plugin>
- <version.compiler.plugin>3.12.1</version.compiler.plugin>
- <version.dependency.plugin>3.3.0</version.dependency.plugin>
- <version.deploy.plugin>2.8.2</version.deploy.plugin>
- <version.enforcer.plugin>3.1.0</version.enforcer.plugin>
+ <version.checkstyle.plugin>3.4.0</version.checkstyle.plugin>
+ <version.clean.plugin>3.4.0</version.clean.plugin>
Review Comment:
same comment as above
##########
packages/stunner-editors/pom.xml:
##########
@@ -187,29 +187,29 @@
<version.antrun.plugin>1.8</version.antrun.plugin>
<version.buildhelper.plugin>3.0.0</version.buildhelper.plugin>
<version.bundle.plugin>3.3.0</version.bundle.plugin>
- <version.checkstyle.plugin>3.2.0</version.checkstyle.plugin>
- <version.clean.plugin>3.1.0</version.clean.plugin>
- <version.compiler.plugin>3.12.1</version.compiler.plugin>
- <version.dependency.plugin>3.3.0</version.dependency.plugin>
- <version.deploy.plugin>2.8.2</version.deploy.plugin>
- <version.enforcer.plugin>3.1.0</version.enforcer.plugin>
+ <version.checkstyle.plugin>3.4.0</version.checkstyle.plugin>
+ <version.clean.plugin>3.4.0</version.clean.plugin>
+ <version.compiler.plugin>3.13.0</version.compiler.plugin>
+ <version.dependency.plugin>3.7.1</version.dependency.plugin>
+ <version.deploy.plugin>3.1.2</version.deploy.plugin>
+ <version.enforcer.plugin>3.5.0</version.enforcer.plugin>
Review Comment:
same comment as above
##########
packages/stunner-editors/pom.xml:
##########
@@ -187,29 +187,29 @@
<version.antrun.plugin>1.8</version.antrun.plugin>
<version.buildhelper.plugin>3.0.0</version.buildhelper.plugin>
<version.bundle.plugin>3.3.0</version.bundle.plugin>
- <version.checkstyle.plugin>3.2.0</version.checkstyle.plugin>
- <version.clean.plugin>3.1.0</version.clean.plugin>
- <version.compiler.plugin>3.12.1</version.compiler.plugin>
- <version.dependency.plugin>3.3.0</version.dependency.plugin>
- <version.deploy.plugin>2.8.2</version.deploy.plugin>
- <version.enforcer.plugin>3.1.0</version.enforcer.plugin>
+ <version.checkstyle.plugin>3.4.0</version.checkstyle.plugin>
+ <version.clean.plugin>3.4.0</version.clean.plugin>
+ <version.compiler.plugin>3.13.0</version.compiler.plugin>
+ <version.dependency.plugin>3.7.1</version.dependency.plugin>
+ <version.deploy.plugin>3.1.2</version.deploy.plugin>
+ <version.enforcer.plugin>3.5.0</version.enforcer.plugin>
<version.failsafe.plugin>${version.surefire.plugin}</version.failsafe.plugin>
- <version.install.plugin>2.5.2</version.install.plugin>
+ <version.install.plugin>3.1.2</version.install.plugin>
Review Comment:
same comment as above
##########
packages/dev-deployment-kogito-quarkus-blank-app/pom.xml:
##########
@@ -41,19 +41,18 @@
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
- <!-- Maven versions -->
- <version.maven.artifact.plugin>3.4.1</version.maven.artifact.plugin>
+ <!-- Plugins version -->
+ <version.codehaus.flatten.plugin>1.6.0</version.codehaus.flatten.plugin>
+ <version.maven.clean.plugin>3.4.0</version.maven.clean.plugin>
<version.maven.compiler.plugin>3.13.0</version.maven.compiler.plugin>
- <version.maven.resources.plugin>3.3.1</version.maven.resources.plugin>
- <version.maven.failsafe.plugin>3.0.0-M7</version.maven.failsafe.plugin>
- <version.maven.surefire.plugin>3.5.0</version.maven.surefire.plugin>
- <version.maven.install.plugin>3.1.3</version.maven.install.plugin>
+ <version.maven.dependency.plugin>3.7.1</version.maven.dependency.plugin>
<version.maven.deploy.plugin>3.1.2</version.maven.deploy.plugin>
+
<version.maven.failsafe.plugin>${version.maven.surefire.plugin}</version.maven.failsafe.plugin>
+ <version.maven.install.plugin>3.1.3</version.maven.install.plugin>
Review Comment:
seems to be unused version.maven.install.plugin
##########
packages/stunner-editors/pom.xml:
##########
@@ -187,29 +187,29 @@
<version.antrun.plugin>1.8</version.antrun.plugin>
<version.buildhelper.plugin>3.0.0</version.buildhelper.plugin>
<version.bundle.plugin>3.3.0</version.bundle.plugin>
- <version.checkstyle.plugin>3.2.0</version.checkstyle.plugin>
- <version.clean.plugin>3.1.0</version.clean.plugin>
- <version.compiler.plugin>3.12.1</version.compiler.plugin>
- <version.dependency.plugin>3.3.0</version.dependency.plugin>
- <version.deploy.plugin>2.8.2</version.deploy.plugin>
- <version.enforcer.plugin>3.1.0</version.enforcer.plugin>
+ <version.checkstyle.plugin>3.4.0</version.checkstyle.plugin>
+ <version.clean.plugin>3.4.0</version.clean.plugin>
+ <version.compiler.plugin>3.13.0</version.compiler.plugin>
+ <version.dependency.plugin>3.7.1</version.dependency.plugin>
+ <version.deploy.plugin>3.1.2</version.deploy.plugin>
+ <version.enforcer.plugin>3.5.0</version.enforcer.plugin>
<version.failsafe.plugin>${version.surefire.plugin}</version.failsafe.plugin>
- <version.install.plugin>2.5.2</version.install.plugin>
+ <version.install.plugin>3.1.2</version.install.plugin>
Review Comment:
version misalignment is also for:
- `version.maven.artifact.plugin`
- `version.resources.plugin`
- `version.site.plugin`
- `version.surefire.plugin`
- `version.war.plugin`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org
For additional commands, e-mail: commits-h...@kie.apache.org
