jomarko commented on code in PR #3823: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3823#discussion_r1905034916
########## kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn: ########## @@ -16,9 +16,9 @@ ~ specific language governing permissions and limitations ~ under the License. --> - -<dmn:definitions xmlns:dmn="http://www.omg.org/spec/DMN/20180521/MODEL/" xmlns="decision" xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/" xmlns:kie="http://www.drools.org/kie/dmn/1.2" xmlns:dmndi="http://www.omg.org/spec/DMN/20180521/DMNDI/" xmlns:dc="http://www.omg.org/spec/DMN/20180521/DC/" xmlns:feel="http://www.omg.org/spec/DMN/20180521/FEEL/" id="_9efe7fc6-f41b-422c-accd-95dcaaa67a39" name="Vacations" typeLanguage="http://www.omg.org/spec/DMN/20180521/FEEL/" namespace="decision"> - <dmn:extensionElements/> +<?xml version="1.0" encoding="UTF-8" ?> Review Comment: failed tests seems to be related to this : ``` DMN Validation schema and model validation contained errors You may configure kogito.decisions.validation=IGNORE to ignore validation errors DMN Validation errors: : DMN: Failed XML validation of DMN file: /home/jenkins/jenkins-agent/workspace/_jobs_kogito-runtimes-pr_PR-3823/kogito-pipelines/bc/apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-decisions/src/test/resources/decision/models/vacationDays/vacationDays.dmn - The processing instruction target matching "[xX][mM][lL]" is not allowed. (DMN model failed XML schema validation) , : DMN: One of the supplied DMN Models has failed validation; cannot proceed to validation of the remaining DMN Models. (DMN Validation stopped on failed validation for some DMN Model) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org For additional commands, e-mail: commits-h...@kie.apache.org