Kusuma04-dev commented on PR #2846: URL: https://github.com/apache/incubator-kie-tools/pull/2846#issuecomment-2582414919
> Thank you @Kusuma04-dev . I suspect that `Button` element was added just for styling purposes. If you notice, in the UI the Kebab Element has a different style with your changes. > > Said so, your changes are correct from my point of view. if my above suspect is true, you can even totally remove that element, and not replace it with a div, unless we need that to stop the event propagation to the Kebab element. (to be checked) > > My only doubt is about the element's style. Should we preserve it? Hi Yeser, Yeah i have kept div tag to stop event propogation ,also i don't see difference in the style ,as i have attached one ss with full screen and another with half screen , it might be looking different . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org For additional commands, e-mail: commits-h...@kie.apache.org
