tiagobento commented on code in PR #2720:
URL:
https://github.com/apache/incubator-kie-tools/pull/2720#discussion_r1915074378
##########
packages/online-editor/src/dmnRunner/DmnRunnerDrawer.tsx:
##########
@@ -38,7 +41,7 @@ export function DmnRunnerDrawer(props:
React.PropsWithChildren<{}>) {
}
panelContent={
<DmnRunnerErrorBoundary>
- <DmnRunnerDrawerPanelContent />
+ <DmnRunnerDrawerPanelContent {...props} />
Review Comment:
This can be potentially dangerous... try and find some resources about this
:)
##########
packages/form-dmn/src/FormDmnOutputs.tsx:
##########
@@ -258,7 +262,18 @@ export function FormDmnOutputs({ openExecutionTab,
...props }: FormDmnOutputsPro
onAnimationEnd={(e) => onAnimationEnd(e, index)}
>
<CardTitle>
- <Title headingLevel={"h2"}>{dmnFormResult.decisionName}</Title>
+ <Flex justifyContent={{ default: "justifyContentSpaceBetween" }}>
+ <Title headingLevel={"h2"}>{dmnFormResult.decisionName}</Title>
+ {props.openBoxedExpressionEditor !== undefined && (
+ <Button
+ variant={"plain"}
+ title={`Open ${dmnFormResult.decisionName} expression`}
+ icon={<ArrowUpIcon />}
+ data-navigate-to-expression-id={dmnFormResult.decisionId}
+ onClick={() =>
props.openBoxedExpressionEditor?.(dmnFormResult.decisionId)}
+ />
+ )}
+ </Flex>
Review Comment:
Warnings from ESLint on this hook call.
##########
packages/dmn-editor-envelope/src/DmnEditorFactory.tsx:
##########
@@ -42,7 +42,7 @@ export class DmnEditorFactory implements
EditorFactory<Editor, KogitoEditorChann
}
export class DmnEditorInterface implements Editor {
- private self: DmnEditorRoot;
+ protected self: DmnEditorRoot;
Review Comment:
Why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
