rhkp commented on code in PR #2697:
URL:
https://github.com/apache/incubator-kie-tools/pull/2697#discussion_r1924310948
##########
packages/sonataflow-image-common/resources/scripts/build-kogito-apps-components.sh:
##########
@@ -56,6 +56,9 @@ if [ ! -z "${CYPRESS_BINARY_URL}" ]; then
fi
case ${imageName} in
+ "incubator-kie-kogito-db-migrator-tool")
+ contextDir="db-migrator-tool/image"
+ ;;
Review Comment:
@ricardozanini @tiagobento
- The initial/original implementation was independent of
`sonataflow-image-common`. However on Dec 09, 2024 based on this
[comment](https://github.com/apache/incubator-kie-tools/pull/2697?new_mergebox=false#discussion_r1876832455)
by @ricardozanini we started using sonataflow-image-common.
- Thus sonataflow-image-common package is vital for the current
implementation and we cannot remove this file.
Please advise.
PS: If I understand it right other images are making use of this too and we
are in-line with other established practice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
