pefernan commented on code in PR #2187:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2187#discussion_r1941713057
##########
jobs-service/jobs-service-common/src/main/java/org/kie/kogito/jobs/service/reflection/ReflectionConfiguration.java:
##########
@@ -18,42 +18,71 @@
*/
package org.kie.kogito.jobs.service.reflection;
+import org.kie.kogito.event.AbstractDataEvent;
+import org.kie.kogito.event.cloudevents.SpecVersionDeserializer;
+import org.kie.kogito.event.cloudevents.SpecVersionSerializer;
+import org.kie.kogito.jobs.api.event.CancelJobRequestEvent;
+import org.kie.kogito.jobs.service.adapter.ScheduledJobAdapter;
+import org.kie.kogito.jobs.service.api.Job;
+import org.kie.kogito.jobs.service.api.JobLookupId;
+import org.kie.kogito.jobs.service.api.Recipient;
+import org.kie.kogito.jobs.service.api.Schedule;
+import org.kie.kogito.jobs.service.api.event.CreateJobEvent;
+import org.kie.kogito.jobs.service.api.event.DeleteJobEvent;
+import org.kie.kogito.jobs.service.api.event.JobCloudEvent;
+import
org.kie.kogito.jobs.service.api.event.serialization.JobCloudEventDeserializer;
+import
org.kie.kogito.jobs.service.api.event.serialization.JobCloudEventSerializer;
+import org.kie.kogito.jobs.service.api.recipient.http.HttpRecipient;
+import
org.kie.kogito.jobs.service.api.recipient.http.HttpRecipientBinaryPayloadData;
+import
org.kie.kogito.jobs.service.api.recipient.http.HttpRecipientJsonPayloadData;
+import
org.kie.kogito.jobs.service.api.recipient.http.HttpRecipientStringPayloadData;
+import org.kie.kogito.jobs.service.api.recipient.sink.SinkRecipient;
+import
org.kie.kogito.jobs.service.api.recipient.sink.SinkRecipientBinaryPayloadData;
+import
org.kie.kogito.jobs.service.api.recipient.sink.SinkRecipientJsonPayloadData;
+import org.kie.kogito.jobs.service.api.schedule.cron.CronSchedule;
+import org.kie.kogito.jobs.service.api.schedule.timer.TimerSchedule;
+import org.kie.kogito.jobs.service.events.JobDataEvent;
+import org.kie.kogito.jobs.service.repository.marshaller.TriggerMarshaller;
+import org.kie.kogito.jobs.service.resource.error.ErrorResponse;
+
import io.quarkus.runtime.annotations.RegisterForReflection;
/**
* Placeholder for registering classes for reflection instead of using
reflection-config.json approach or tagging
* them individually.
*/
@RegisterForReflection(
- classNames = {
- "org.kie.kogito.event.cloudevents.SpecVersionSerializer",
- "org.kie.kogito.event.AbstractDataEvent",
- "org.kie.kogito.jobs.service.events.JobDataEvent",
-
"org.kie.kogito.jobs.service.repository.marshaller.RecipientMarshaller$HTTPRecipientAccessor",
-
"org.kie.kogito.jobs.service.job.model.ScheduledJobAdapter$ProcessPayload",
-
"org.kie.kogito.jobs.service.repository.marshaller.TriggerMarshaller$PointInTimeTriggerAccessor",
-
"org.kie.kogito.jobs.service.repository.marshaller.TriggerMarshaller$IntervalTriggerAccessor",
-
"org.kie.kogito.jobs.service.repository.marshaller.TriggerMarshaller$SimpleTimerTriggerAccessor",
- "org.kie.kogito.jobs.api.event.CancelJobRequestEvent$JobId",
-
"org.kie.kogito.jobs.service.api.event.serialization.SpecVersionSerializer",
-
"org.kie.kogito.jobs.service.api.event.serialization.SpecVersionDeserializer",
- "org.kie.kogito.jobs.service.api.Job",
- "org.kie.kogito.jobs.service.api.JobLookupId",
- "org.kie.kogito.jobs.service.api.Recipient",
- "org.kie.kogito.jobs.service.api.recipient.http.HttpRecipient",
-
"org.kie.kogito.jobs.service.api.recipient.http.HttpRecipientStringPayloadData",
-
"org.kie.kogito.jobs.service.api.recipient.http.HttpRecipientBinaryPayloadData",
-
"org.kie.kogito.jobs.service.api.recipient.http.HttpRecipientJsonPayloadData",
- "org.kie.kogito.jobs.service.api.recipient.sink.SinkRecipient",
-
"org.kie.kogito.jobs.service.api.recipient.sink.SinkRecipientBinaryPayloadData",
-
"org.kie.kogito.jobs.service.api.recipient.sink.SinkRecipientJsonPayloadData",
- "org.kie.kogito.jobs.service.api.Schedule",
- "org.kie.kogito.jobs.service.api.schedule.timer.TimerSchedule",
- "org.kie.kogito.jobs.service.api.schedule.cron.CronSchedule",
- "org.kie.kogito.jobs.service.api.event.JobCloudEvent",
- "org.kie.kogito.jobs.service.api.event.CreateJobEvent",
- "org.kie.kogito.jobs.service.api.event.DeleteJobEvent",
- "org.kie.kogito.jobs.service.resource.error.ErrorResponse"
+ targets = {
+ SpecVersionSerializer.class,
Review Comment:
@wmedvede I see we have this `SpecVersionSerializer` &
`SpecVersionDeserializer` classes declared in two differnt packages, and both
look pretty much the same, do you think we can unify them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
