gitgabrio commented on code in PR #6259:
URL: 
https://github.com/apache/incubator-kie-drools/pull/6259#discussion_r1961773620


##########
kie-dmn/kie-dmn-test-resources/src/test/resources/valid_models/DMNv1_5/ConstraintsChecks.dmn:
##########
@@ -22,7 +22,7 @@
                       xmlns:dc="http://www.omg.org/spec/DMN/20180521/DC/";
                       xmlns:di="http://www.omg.org/spec/DMN/20180521/DI/";
                       
xmlns:dmndi="https://www.omg.org/spec/DMN/20230324/DMNDI/";
-                      xmlns:feel="http://www.omg.org/spec/DMN/20180521/FEEL/";
+                      xmlns:feel="https://www.omg.org/spec/DMN/20230324/FEEL/";

Review Comment:
   DMN version is an atomic entity that comprise also FEEL, DMNDI, DI, and DC.
   Even if they are defined under different namespaces for technical reason, as 
a matter of fact they are all part of the same version.
   So, switching DMN version should imply that all of them are kept in sync 
with that version, otherwise the model will be in inconsistent state.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to