ljmotta commented on code in PR #2942:
URL:
https://github.com/apache/incubator-kie-tools/pull/2942#discussion_r1980039470
##########
packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/evaluationHighlights/evaluation-highlights-skipped.png:
##########
Review Comment:
The new E2E images look wrong. The `skipped` are with the `success` badge,
and the `success` ones are with the `skipped` badge.
##########
packages/dmn-editor-envelope/src/DmnEditorRoot.tsx:
##########
@@ -96,6 +97,7 @@ export class DmnEditorRoot extends
React.Component<DmnEditorRootProps, DmnEditor
keyboardShortcutsRegisterIds: [],
keyboardShortcutsRegistered: false,
error: undefined,
+ evaluationResultsByNodeId: new Map<string,
DmnEditor.NodeEvaluationResults>(),
Review Comment:
with the `EvaluationResultsByNodeId` I believe you don't need to specify the
`Map` type: `new Map()` should suffice.
##########
packages/dmn-editor-envelope/src/DmnEditorRoot.tsx:
##########
@@ -74,6 +74,7 @@ export type DmnEditorRootState = {
keyboardShortcutsRegisterIds: number[];
keyboardShortcutsRegistered: boolean;
error: Error | undefined;
+ evaluationResultsByNodeId: Map<string, DmnEditor.NodeEvaluationResults>;
Review Comment:
I'm not sure if I've followed. Why not use the `EvaluationResultsByNodeId`,
which is the same type used in the `DmnEditor`?
`evaluationResultsByNodeId: EvaluationResultsByNodeId`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
