github-advanced-security[bot] commented on code in PR #2987:
URL:
https://github.com/apache/incubator-kie-tools/pull/2987#discussion_r1990318774
##########
packages/cors-proxy/src/proxy/ExpressCorsProxy.ts:
##########
@@ -153,11 +154,23 @@
}
private getProxyAgent(info: ProxyRequestInfo): https.Agent | undefined {
- if (info.insecurelyDisableTLSCertificateValidation &&
info.proxyUrl.protocol === "https:") {
- return new https.Agent({
- rejectUnauthorized: false,
- });
+ const proxyUrl = process.env.HTTPS_PROXY || process.env.HTTP_PROXY;
+
+ const agentOptions =
+ info.insecurelyDisableTLSCertificateValidation && info.proxyUrl.protocol
=== "https:"
+ ? { rejectUnauthorized: false }
Review Comment:
## Disabling certificate validation
Disabling certificate validation is strongly discouraged.
[Show more
details](https://github.com/apache/incubator-kie-tools/security/code-scanning/1020)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
