Adarshvk98 commented on PR #3031: URL: https://github.com/apache/incubator-kie-tools/pull/3031#issuecomment-2769188237
> Thank you for the PR. Here is my feedback in few points. > > ### 01 DESKTOP vs WEB > In code I see `settings.channelType === ChannelType.VSCODE_DESKTOP || settings.channelType === ChannelType.VSCODE_WEB`. I have tried just a desktop. Is here anyone who tried web? > - I'm not sure about testing in VSCode Web, as I haven't explored this option before. I couldn't find a way to install a VSIX file in the Extensions tab. If someone could guide me or help me do so, I can test it. > ### 02 search > imagine there is class `Person`. User is not able to search it using string like `son` or `person`. User is able to search it just using the proper lower/upper case match and the `startsWith` letters. For example `Pers` will find `Person` > > maybe we should do similar updates as we do in #3033 ? > > ### 03 select multiple classes > Once I selected two classes `Person` and `Person2`, the first one is always imported/loaded as empty structure. However, checking java code, `Person` it is not empty.   > - I agree that there is room for improvement in these areas. However, since I haven't touched the overall functionality of the `import-java-classes-component` package (apart from rearranging the component to make it reusable in the new DMN editor), I think these improvements can be considered for a later stage ? > ### 04 Activator hint > is currently: > > ``` > Not available, please check if 'Language Support for Java by Red Hat' extension is correctly installed and the Activator Java Class is present in your project. > ``` > > from the ^ it is not so clear to me it should look like:https://github.com/yesamer/dmn-javaclasses-example/blob/main/src/main/java/Activator.java > - The error message is likely an existing message in the old DMN editor and can be considered an improvement. > Points 2 and 3 are probably also in old editor? Probably we can handle them in separate tickets potentially? What is your opinion aboit 1 and 4? - I think the current goal is to bring the same feature from the old DMN editor to the new one. While the mentioned points are improvements, I'm not sure if they should be addressed along with this or as a separate tickets. I'd like to hear your thoughts on this, @tiagobento and @yesamer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
