ricardozanini commented on code in PR #3039:
URL:
https://github.com/apache/incubator-kie-tools/pull/3039#discussion_r2022914402
##########
packages/sonataflow-operator/internal/controller/profiles/common/constants/workflows.go:
##########
@@ -18,20 +18,17 @@
package constants
const (
- MicroprofileServiceCatalogPropertyPrefix =
"org.kie.kogito.addons.discovery."
- KogitoOutgoingEventsURL =
"mp.messaging.outgoing.kogito_outgoing_stream.url"
- KogitoOutgoingEventsConnector =
"mp.messaging.outgoing.kogito_outgoing_stream.connector"
- KogitoIncomingEventsConnector =
"mp.messaging.incoming.kogito_incoming_stream.connector"
- KogitoIncomingEventsPath =
"mp.messaging.incoming.kogito_incoming_stream.path"
- KnativeHealthEnabled =
"org.kie.kogito.addons.knative.eventing.health-enabled"
- KnativeInjectedEnvVar = "${K_SINK}"
- TriggerFinalizer = "trigger-deletion"
- WorkflowFinalizer = "workflow-deletion"
- QuarkusDevUICorsEnabled =
"quarkus.dev-ui.cors.enabled"
- QuarkusHttpCors = "quarkus.http.cors"
- QuarkusHttpCorsOrigins =
"quarkus.http.cors.origins"
- KogitoEventsGrouping = "kogito.events.grouping"
- KogitoEventsGroupingBinary =
"kogito.events.grouping.binary"
- KogitoEventsGroupingCompress =
"kogito.events.grouping.compress"
- SendWorkflowDefinitionsStatusUpdateEventError = "An error was produced
while sending a workflow definition status change event."
+ KogitoOutgoingEventsURL =
"mp.messaging.outgoing.kogito_outgoing_stream.url"
+ KogitoOutgoingEventsConnector =
"mp.messaging.outgoing.kogito_outgoing_stream.connector"
+ KogitoIncomingEventsConnector =
"mp.messaging.incoming.kogito_incoming_stream.connector"
+ KogitoIncomingEventsPath =
"mp.messaging.incoming.kogito_incoming_stream.path"
+ KnativeHealthEnabled =
"org.kie.kogito.addons.knative.eventing.health-enabled"
+ KnativeInjectedEnvVar = "${K_SINK}"
+ TriggerFinalizer = "trigger-deletion"
+ WorkflowFinalizer = "workflow-deletion"
+ QuarkusDevUICorsEnabled = "quarkus.dev-ui.cors.enabled"
+ QuarkusDevUIHosts = "quarkus.dev-ui.hosts"
+ KogitoEventsGrouping = "kogito.events.grouping"
+ KogitoEventsGroupingBinary = "kogito.events.grouping.binary"
+ KogitoEventsGroupingCompress = "kogito.events.grouping.compress"
Review Comment:
The removed consts weren't being used anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]