yesamer commented on code in PR #6387: URL: https://github.com/apache/incubator-kie-drools/pull/6387#discussion_r2182593488
########## kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/BaseFEELFunction.java: ########## @@ -21,16 +21,15 @@ import java.lang.reflect.Method; import java.lang.reflect.Modifier; -import java.util.Arrays; -import java.util.Collections; -import java.util.List; -import java.util.Set; +import java.util.*; import java.util.function.Function; import java.util.function.Supplier; import java.util.stream.Collectors; import java.util.stream.IntStream; import java.util.stream.Stream; +import org.kie.dmn.api.core.DMNModel; +import org.kie.dmn.api.core.DMNRuntime; Review Comment: @gitgabrio Why you introduced those new imports? ########## kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/BaseFEELFunction.java: ########## @@ -21,16 +21,15 @@ import java.lang.reflect.Method; import java.lang.reflect.Modifier; -import java.util.Arrays; -import java.util.Collections; -import java.util.List; -import java.util.Set; +import java.util.*; Review Comment: @gitgabrio Ouch! ########## kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/BaseFEELFunction.java: ########## @@ -44,6 +43,7 @@ import org.kie.dmn.feel.runtime.events.InvalidParametersEvent; import org.kie.dmn.feel.util.BuiltInTypeUtils; import org.kie.dmn.feel.util.Either; +import org.kie.dmn.model.api.Definitions; Review Comment: @gitgabrio Same as above -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
