tkobayas commented on PR #6430:
URL:
https://github.com/apache/incubator-kie-drools/pull/6430#issuecomment-3205251967
Thoughts:
Calling `disablePropertyReactivity` only when the
`JoinNode.rightInferredMask` is empty.
```diff
diff --git
a/drools-core/src/main/java/org/drools/core/reteoo/EvalConditionNode.java
b/drools-core/src/main/java/org/drools/core/reteoo/EvalConditionNode.java
index 83485fad25..98a891dc2c 100644
--- a/drools-core/src/main/java/org/drools/core/reteoo/EvalConditionNode.java
+++ b/drools-core/src/main/java/org/drools/core/reteoo/EvalConditionNode.java
@@ -91,7 +91,7 @@ public class EvalConditionNode extends LeftTupleSource
@Override
protected void initInferredMask(LeftTupleSource leftInput) {
super.initInferredMask( leftInput );
- if (NodeTypeEnums.isBetaNode(leftInput)) {
+ if (NodeTypeEnums.isBetaNode(leftInput) &&
((BetaNode)leftInput).getRightInferredMask().isEmpty() ) {
((BetaNode)leftInput).disablePropertyReactivity();
}
}
```
It passes `testModifyEvalAfterJoinWithEmptyConstraint`, but fails with
`testModifyEvalAfterJoinWithMatchingAlpha`. It doesn't seem to be a fundamental
fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
