tiagobento commented on code in PR #3268:
URL:
https://github.com/apache/incubator-kie-tools/pull/3268#discussion_r2334030022
##########
packages/dmn-editor/src/mutations/deleteEdge.ts:
##########
@@ -44,7 +44,7 @@ export function deleteEdge({
mode: EdgeDeletionMode;
externalModelsByNamespace: ExternalModelsIndex | undefined;
}) {
- if (edge.dmnObject.namespace === definitions["@_namespace"]) {
+ if (!edge.dmnObject.normalizedNamespace) {
Review Comment:
That's the fix for edge deletion. A normalized namespace equals `""` or
`undefined` if it is the same as `thisDmn`'s namespace. We can only edit
requirements on `thisDmn`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]