Rikkola commented on code in PR #6460:
URL:
https://github.com/apache/incubator-kie-drools/pull/6460#discussion_r2361953444
##########
drools-base/src/main/java/org/drools/base/rule/Declaration.java:
##########
@@ -235,42 +235,29 @@ public Object getValue(ValueResolver valueResolver,
FactHandle fh) {
public Object getValue(ValueResolver valueResolver,
final Object object) {
- return this.readAccessor.getValue( valueResolver, object );
+ return this.readAccessor.getValue(valueResolver, object);
}
- public char getCharValue(ValueResolver valueResolver,
- final Object object) {
- return this.readAccessor.getCharValue(valueResolver, object);
- }
-
- public int getIntValue(ValueResolver valueResolver,
- final Object object) {
- return this.readAccessor.getIntValue(valueResolver, object);
- }
-
- public byte getByteValue(ValueResolver valueResolver,
+ public long getWholeNumberValue(ValueResolver valueResolver,
final Object object) {
- return this.readAccessor.getByteValue(valueResolver, object);
+ return this.readAccessor.getWholeNumberValue(valueResolver, object);
}
- public short getShortValue(ValueResolver valueResolver,
- final Object object) {
- return this.readAccessor.getShortValue(valueResolver, object);
- }
-
- public long getLongValue(ValueResolver valueResolver,
- final Object object) {
- return this.readAccessor.getLongValue(valueResolver, object);
+ public double getDecimalValue(ValueResolver valueResolver,
+ final Object object) {
+ return this.readAccessor.getDecimalValue(valueResolver, object);
}
- public float getFloatValue(ValueResolver valueResolver,
- final Object object) {
- return this.readAccessor.getFloatValue(valueResolver, object);
+ @Deprecated // TODO ask why this is needed in OOPathQueries, based on the
tests at least
+ public double getDoubleValue(ValueResolver valueResolver,
+ final Object object) {
+ return this.readAccessor.getDecimalValue(valueResolver, object);
Review Comment:
Ok, after my latest changes these do not cause OOPathQueries any issues.
Removing these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
