wmedvede commented on code in PR #2271:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2271#discussion_r2388611161
##########
data-index/data-index-quarkus/kogito-addons-quarkus-data-index/kogito-addons-quarkus-data-index-common/runtime/src/main/java/org/kie/kogito/index/addon/config/DataIndexBuildConfig.java:
##########
@@ -18,17 +18,22 @@
*/
package org.kie.kogito.index.addon.config;
-import io.quarkus.runtime.annotations.ConfigItem;
+import java.util.Optional;
+
import io.quarkus.runtime.annotations.ConfigPhase;
import io.quarkus.runtime.annotations.ConfigRoot;
+import io.smallrye.config.ConfigMapping;
-@ConfigRoot(name = "kogito.data-index", phase = ConfigPhase.BUILD_TIME)
-public class DataIndexBuildConfig {
+@ConfigMapping(prefix = "kogito.data-index.build")
Review Comment:
@pefernan @gmunozfe @fjtirado
Consiering that the new config mechanism is more strict, and to avoid mixing
build and runtime properties that can produce validation errors, we add the
build properties in a specific prefix "kogito.data-idex.build".
btw: currently the only build time property we have is
kogito.data-index.build.blocking and is not exposed, nor used outside the
project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
