fjtirado commented on code in PR #4213:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/4213#discussion_r2997482801
##########
kogito-workitems/kogito-rest-workitem/src/main/java/org/kogito/workitem/rest/RestWorkItemHandler.java:
##########
@@ -176,19 +178,18 @@ public Optional<WorkItemTransition>
activateWorkItemHandler(KogitoWorkItemManage
}
if (isEmpty(path)) {
path = endPoint;
- logger.debug("Path is empty, using whole endpoint {}", endPoint);
+ logger.info("Path is empty, using whole endpoint {}", endPoint);
}
if (isEmpty(protocol)) {
protocol = port == DEFAULT_SSL_PORT ? HTTPS_PROTOCOL :
HTTP_PROTOCOL;
}
- logger.debug("Invoking request with protocol {} host {} port {} and
endpoint {}", protocol, host, port, path);
WebClient client = isHttps(protocol) ? httpsClient : httpClient;
HttpRequest<Buffer> request = client.request(method, port, host, path);
WorkItemRecordParameters.recordInputParameters(workItem, parameters);
- requestDecorators.forEach(d -> d.decorate(workItem, parameters,
request));
- authDecorators.forEach(d -> d.decorate(workItem, parameters, request));
- paramsDecorator.decorate(workItem, parameters, request);
+ requestDecorators.forEach(d -> d.decorate(workItem, parameters,
request, handler));
Review Comment:
In other words, essentially this class should not have been modified, the
AuthDecorator can be done without changing anything here.
##########
kogito-workitems/kogito-rest-workitem/src/main/java/org/kogito/workitem/rest/RestWorkItemHandler.java:
##########
@@ -176,19 +178,18 @@ public Optional<WorkItemTransition>
activateWorkItemHandler(KogitoWorkItemManage
}
if (isEmpty(path)) {
path = endPoint;
- logger.debug("Path is empty, using whole endpoint {}", endPoint);
+ logger.info("Path is empty, using whole endpoint {}", endPoint);
}
if (isEmpty(protocol)) {
protocol = port == DEFAULT_SSL_PORT ? HTTPS_PROTOCOL :
HTTP_PROTOCOL;
}
- logger.debug("Invoking request with protocol {} host {} port {} and
endpoint {}", protocol, host, port, path);
WebClient client = isHttps(protocol) ? httpsClient : httpClient;
HttpRequest<Buffer> request = client.request(method, port, host, path);
WorkItemRecordParameters.recordInputParameters(workItem, parameters);
- requestDecorators.forEach(d -> d.decorate(workItem, parameters,
request));
- authDecorators.forEach(d -> d.decorate(workItem, parameters, request));
- paramsDecorator.decorate(workItem, parameters, request);
+ requestDecorators.forEach(d -> d.decorate(workItem, parameters,
request, handler));
Review Comment:
In other words, essentially this class should not have been modified, the
AuthDecorator can be implemented without changing anything here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
