Rikkola commented on issue #6422: URL: https://github.com/apache/incubator-kie-drools/issues/6422#issuecomment-4396364041
So I did the fix in the https://github.com/apache/incubator-kie-drools/pull/6631 after I managed to reproduce, but then on review Paolo said that the test I added passes without the change. It is possible I managed to use main that was behind somehow. When I was investigating what fixed it. I found this: > Then the next issue arises. If the branch condition is evaluated as default -> break -> default (like the test case). The deleted (= removeDormantTuple is called) branchTuples.mainLeftTuple is updated, so modifyActiveTuple causes NPE because it calls removeDormantTuple to a tuple which was already removed from dormantMatches LinkedList. https://github.com/apache/incubator-kie-drools/pull/6461#discussion_r2362373118 So that kind of masks the bug, but the sentence hints that it still is an issue. My fix is basically the same as what @dcmaf has, but if @dcmaf manages to make an unit tests that hits the bug in a reasonable way we can just get a PR from him and merge that. Or I can make a PR an we merge that, both are fine by me. What I still need to search is the reason why this is happening and I have that in my local Claude logs. I will be back with more info. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
